Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression when updating from 1.34 to 1.35 #4528

Open
Imperatorn opened this issue Nov 14, 2023 · 4 comments
Open

Performance regression when updating from 1.34 to 1.35 #4528

Imperatorn opened this issue Nov 14, 2023 · 4 comments

Comments

@Imperatorn
Copy link

See:

jinyus/related_post_gen#427
jinyus/related_post_gen#414 (comment)

@jinyus
Copy link

jinyus commented Nov 14, 2023

The regression happened after upgrading from 1.34.0-beta1 -> 1.35.0

jinyus/related_post_gen#429 (comment)

Input Size 1.34.0-beta1 1.35.0 % Change
5k posts 25.75 ms 32.371 ms 25.6%
20k posts 327.954 ms 442.511 ms 34.8%
60k posts 2815.13 ms 3852.69 ms 36.9%

@cyrusmsk
Copy link

I thought it is because “low” power CPU of the Azure machine. But in more powerful CPU situation is the same. However, not all code affected. Different implementation of the same problem doesn’t suffer from regression.

@cyrusmsk
Copy link

cyrusmsk commented Dec 7, 2023

It seems the issue has gone in 1.36(beta1).

@cyrusmsk
Copy link

@Imperatorn can you close the issue please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants