Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

AndroidX migration #80

Open
gianlucaparadise opened this issue Jan 16, 2020 · 10 comments · May be fixed by #81
Open

AndroidX migration #80

gianlucaparadise opened this issue Jan 16, 2020 · 10 comments · May be fixed by #81

Comments

@gianlucaparadise
Copy link
Contributor

Is it planned a migration from Android Support to AndroidX for the GalaSoft.MvvmLight.Platform.AndroidSupport package?

In my opinion, this is a really blocking issue because it blocks the migration to AndroidX. The migration is necessary in order to use the latest libraries for the Android Ecosystem.

@MichaelShapiro
Copy link

@gianlucaparadise sorry for unrelated question, can you explain how exactly do you use the GalaSoft.MvvmLight.Platform.AndroidSupport package, please?

@gianlucaparadise
Copy link
Contributor Author

@MichaelShapiro for example, we use the GetRecyclerAdapter method in order to generate an ObservableRecyclerAdapter. Then we set it to a RecyclerView.

Since the ObservableRecyclerAdapter extends android.support.v7.widget.RecyclerView.Adapter, which is now deprecated, we can't set the returned Adapter to an AndroidX RecyclerView.

@MichaelShapiro
Copy link

Oh, ok, I see.. so it is only for certain specific things. I actually use JimBobBennett.MvvmLight.AppCompat lib to make MVVMLight compatible with Android Support Libs (at least for navigation purposes).

As far as I understand the Android X is still in preview, and I personally not migrating until it's all released officially. But this project, MVVMLight, seems to not being maintained anymore, unfortunately. At least I do not see any responses from Laurent for a long time now :(

@gianlucaparadise gianlucaparadise linked a pull request Jan 16, 2020 that will close this issue
@gianlucaparadise
Copy link
Contributor Author

gianlucaparadise commented Jan 16, 2020

As far as I know, AndroidX is not in preview since 1.0.0 (September 2018). Support Libraries are not maintained anymore and Google recommend using the AndroidX libraries in all new projects.

Android X is still in preview

Do you refer to Xamarin.AndroidX?

Anyway, I created a pull request with the migration #81.

@MichaelShapiro
Copy link

@gianlucaparadise - I am so sorry, you are correct - I meant to say that Xamarin.AndroidX is in preview. As a result I am holding off on migration in the production environment.

@gianlucaparadise
Copy link
Contributor Author

That's true, but in my opinion, a preview version of the MvvmLight.Platform.AndroidSupport library migrated to AndroidX would be useful to release.

@gianlucaparadise
Copy link
Contributor Author

I updated the pull request #81 with the latest stable AndroidX packages.

@gianlucaparadise
Copy link
Contributor Author

Hi @MichaelShapiro ,
Is the merge of #81 planned?

Thanks.

@andrewescutia
Copy link

I need this functionality as well. Is this project dead? @gianlucaparadise did you just end up forking the project and making the changes for yourself?

@gianlucaparadise
Copy link
Contributor Author

@andrewescutia Yes, I ended up forking the project and creating a temporary Nuget to be used until the official one is released.

In case you need them:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants