Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard unknown/invalid/etc. attestations if "none" is allowed #25

Open
My1 opened this issue Nov 2, 2020 · 2 comments
Open

Discard unknown/invalid/etc. attestations if "none" is allowed #25

My1 opened this issue Nov 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@My1
Copy link
Contributor

My1 commented Nov 2, 2020

basically explains itself. if the attestation cant be verified for any reason, but the format list contains "none", just continue as if there is no attestation rather than erroring.

@lbuchs
Copy link
Owner

lbuchs commented Nov 9, 2020

so why checking a root certificate if you proceed anyway?

@My1
Copy link
Contributor Author

My1 commented Nov 9, 2020

It's not nessecarily for root checks but rather considering that new attestation formats may come around and can't verify for that reason but it is allowed to not send an attestation (i have actually sites reject my solo with attestation but accept it when i told my browser to not send the attestation, lol) to just be treated as not having an attestation.

Also pulling an attestation is not always for enforcing certain security keys or anything, but it can help example identify models and tell users about security issues or updates for their devices, or to help users keep the devices apart easier by telling them what kind of device wach one is.

@lbuchs lbuchs added the enhancement New feature or request label Nov 16, 2020
@My1 My1 mentioned this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants