Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use thumbnails.odysee.com as thumb cdn #1229

Open
tzarebczan opened this issue Dec 29, 2021 · 3 comments
Open

use thumbnails.odysee.com as thumb cdn #1229

tzarebczan opened this issue Dec 29, 2021 · 3 comments
Labels
type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

Also make sure we're using the resizing method- maybe use a size similar to odysee.com mobile (please check code)

@tzarebczan tzarebczan added the type: improvement Existing (or partially existing) functionality needs to be changed label Dec 29, 2021
@kekkyojin
Copy link
Collaborator

This was fixed on Odysee Android but it wasn’t ported to LBRY Android

@tzarebczan
Copy link
Contributor Author

I think that one may be using the image-optimizer URL? Can you also confirm we are passing a width/height/quality params? Would be good to sync those up with mobile odysee.com so one set can be cached properly.

@kekkyojin
Copy link
Collaborator

Yes, @tzarebczan . On Odysee Android, thumbnail.odysee.com/optimize url is being used to get an image file. Width and height are passed to that url, along quality value, which currently is set to 85 over there.

https://github.com/OdyseeTeam/odysee-android/blob/042fc4daff8a60a4430e06c7b83ad6fff7b2bf56/app/src/main/java/com/odysee/app/model/Claim.java#L555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

2 participants