Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Ability to choose to skip rpms who fail gpg check #164

Closed
JamesXNelson opened this issue May 7, 2024 · 6 comments
Closed
Assignees
Labels
feature New feature or request

Comments

@JamesXNelson
Copy link

While mirroring temurin jdk from adoptium, we hit issues w/ some rpms that reliably failed signature checks.

Rather than break the whole mirror, it would be nice to have a checkbox to simply skip any files that failed their checks.

Obviously better to get upstream to not publish junk, but we live in an imperfect world. ^-^

@lbr38
Copy link
Owner

lbr38 commented May 7, 2024

Can you give me the source URL, the release version and the architecture(s) you're trying to mirror please?

I'll see what I can do.

@lbr38 lbr38 self-assigned this May 8, 2024
@lbr38
Copy link
Owner

lbr38 commented May 8, 2024

Currently adding and testing two new settings that should help you handle rpm with invalid signature:

  • When package signature is missing
  • When package signature is invalid

With three possible options:

Capture d’écran du 2024-05-08 14-50-32

This is working fine with adoptium repo. Should be available in the next release.

@JamesXNelson
Copy link
Author

wow! you rock!!

Sorry I didn't get you those urls.

I'll make sure to pull this and try it out when we do the next scheduled mirroring.

@JamesXNelson
Copy link
Author

for deb (the Release vs InRelease) bits:
https://packages.adoptium.net/artifactory/api/gpg/key/public
https://packages.adoptium.net/artifactory/deb jammy main

@lbr38 lbr38 mentioned this issue May 11, 2024
@lbr38 lbr38 added the feature New feature or request label May 11, 2024
@lbr38
Copy link
Owner

lbr38 commented May 13, 2024

Hello

Please update your docker image to the latest version 4.1.0

You will be able to skip rpms with missing/invalid signature by using the When package signature is missing and When package signature is invalid settings from the SETTINGS tab.

Let me know if it's all good.

Thanks!

@lbr38
Copy link
Owner

lbr38 commented May 25, 2024

I guess this is OK

Closing

@lbr38 lbr38 closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants