Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Welcome card to test against Sistent #608

Open
nebula-aac opened this issue May 5, 2024 · 1 comment
Open

Create Welcome card to test against Sistent #608

nebula-aac opened this issue May 5, 2024 · 1 comment
Labels
kind/enhancement Improvement in current feature

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented May 5, 2024

Current Behavior

Testing Sistent Theme Provider against some of the pages and components being used in Meshery Cloud UI.

Screenshot from 2024-05-04 22-09-34

The icons are wrapped with IconButton and the icons have been refactored to use a test base icon that describes how all icons could be. The margin right for the the second item still needs to be adjusted because it is dependent on the size of the icon and the size from the IconButton

Here is the mobile version:

image

I am testing dark mode, but needs more testing before showing the dark mode version of this.

Desired Behavior

Here is a picture of a before and after, of what it could look like, but it is not a final implementation.

Implementation

Acceptance Tests

Mockups


Contributor Guide

@nebula-aac nebula-aac added the kind/enhancement Improvement in current feature label May 5, 2024
@shailpujan88
Copy link

shailpujan88 commented May 26, 2024

Hey @nebula-aac Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

No branches or pull requests

2 participants