Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Redundant npm install step in release workflow? #505

Open
leecalcote opened this issue Feb 13, 2024 · 2 comments
Open

[CI] Redundant npm install step in release workflow? #505

leecalcote opened this issue Feb 13, 2024 · 2 comments
Assignees
@nebula-aac
Labels
area/ci Continuous integration | Build and release

Comments

@leecalcote
Copy link
Member

Current Behavior

The current release workflow has two steps performing npm install. Is this necessary or is it a redundant step that might be eliminated?

sistent/.github/workflows/release.yml

Line 22 in f0b95c4

npm install

Contributor Guides and Resources
@leecalcote leecalcote added the area/ci Continuous integration | Build and release label Feb 13, 2024
@nebula-aac
Copy link
Contributor

It was necessary when I had the error with husky, but not sure now after changing it. I'll review again if this steps is still needed or not.

@leecalcote
Copy link
Member Author

leecalcote commented Feb 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebula-aac nebula-aac

Labels
area/ci Continuous integration | Build and release
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leecalcote @nebula-aac