[Sistent] Feat: JSX syntax highlighting on code pages of sistent #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lakshya <lakshyasatpal372@gmail.com>
|
🚀 Preview for commit 38b3d74 at: https://66409464683dc4aea8e762ba--layer5.netlify.app |
|
Hey @lakshz, let's discuss this on today's website meeting at 5:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/websites if you are available during the meet. |
|
I'm dropping an approving review to this. I wonder if there are any contrary opinions @ritiksaxena124?.. 👀 |
|
@lakshz can you remove the Sistentthemeprovider wrapped from every component. It should be only mentioned at one place because it is wrapped globally and not on each comps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5534
Before
After
Notes for Reviewers
Signed commits