Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sistent] Implement Modal component page #5519

Open
ritiksaxena124 opened this issue May 2, 2024 · 16 comments
Open

[Sistent] Implement Modal component page #5519

ritiksaxena124 opened this issue May 2, 2024 · 16 comments
Assignees
Labels
component/ui Issues related to UI good first issue Good for newcomers kind/enhancement New feature or request

Comments

@ritiksaxena124
Copy link
Contributor

Current Behavior

There is no page for Modal in Sistent

Desired Behavior

Implement the modal page using this Figma mockup


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@ritiksaxena124 ritiksaxena124 added kind/enhancement New feature or request good first issue Good for newcomers component/ui Issues related to UI labels May 2, 2024
Copy link

github-actions bot commented May 2, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

github-actions bot commented May 2, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Rexford74
Copy link

Hi @narasimha-1511! Do you still intend to take up this issue?

@narasimha-1511
Copy link
Member

@Rexford74 I am actuvally confused what to do in this issue , i am not clear .

@Rexford74
Copy link

Rexford74 commented May 7, 2024

Okay. Let me explain a little more. So under components in Sistent on the Layer5 website, there is a page for button component, and one for text input. This issue is to create a page for modals as is seen in the mockups just like we have for buttons & text input.

Let me know if this helps.

@Aryakoste
Copy link
Contributor

Hello @ritiksaxena124 I would like to work on this issue.

@ritiksaxena124
Copy link
Contributor Author

Sure @Aryakoste go ahead 👍

@vishalvivekm
Copy link
Member

Hey @Aryakoste, do you have any updates that you wanna share ?
let's discuss this on today's website meeting at 5:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/websites if you are available during the meet.

@Aryakoste
Copy link
Contributor

Sorry. Not available at that time.

@Aryakoste
Copy link
Contributor

I have completed all the text part of modal component with overview, guidance and code section. Now just the example modals remains. I wanted to ask that for the code of Button and TextInput components there was a component in layer5/sistent node module which in turns use material ui. But for modal there is no component available layer5/sistent or there maybe and idk. So how should i proceed with this should i create custom modal component or something. @ritiksaxena124

@Aryakoste
Copy link
Contributor

And in guidance and code section there are multiple varieties of modals. So do i have to create every variety using components.

@Rexford74
Copy link

I didn't know you were already working on this issue. Was just about to assign another contributor.. 😅. Thank you for raising these concerns @Aryakoste I'll look into it and give you feedback before the end of today.

@hargunkaur286
Copy link
Contributor

Can I work on this issue? @Rexford74

@deauthe
Copy link

deauthe commented May 24, 2024

hey @Rexford74 , is this issue available to work on?

@Aryakoste
Copy link
Contributor

Hello @Rexford74 Any updates on how should i proceed with this issue.

@vishalvivekm
Copy link
Member

Hello @Rexford74 Any updates on how should i proceed with this issue.

@Rexford74 @Aryakoste Let's make sure to discuss this in Monday's websites call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issues related to UI good first issue Good for newcomers kind/enhancement New feature or request
Development

No branches or pull requests

7 participants