-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sistent] Implement Modal component page #5519
Comments
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
1 similar comment
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
Hi @narasimha-1511! Do you still intend to take up this issue? |
@Rexford74 I am actuvally confused what to do in this issue , i am not clear . |
Okay. Let me explain a little more. So under components in Sistent on the Layer5 website, there is a page for button component, and one for text input. This issue is to create a page for modals as is seen in the mockups just like we have for buttons & text input. Let me know if this helps. |
Hello @ritiksaxena124 I would like to work on this issue. |
Sure @Aryakoste go ahead 👍 |
Hey @Aryakoste, do you have any updates that you wanna share ? |
Sorry. Not available at that time. |
I have completed all the text part of modal component with overview, guidance and code section. Now just the example modals remains. I wanted to ask that for the code of Button and TextInput components there was a component in layer5/sistent node module which in turns use material ui. But for modal there is no component available layer5/sistent or there maybe and idk. So how should i proceed with this should i create custom modal component or something. @ritiksaxena124 |
And in guidance and code section there are multiple varieties of modals. So do i have to create every variety using components. |
I didn't know you were already working on this issue. Was just about to assign another contributor.. 😅. Thank you for raising these concerns @Aryakoste I'll look into it and give you feedback before the end of today. |
Can I work on this issue? @Rexford74 |
hey @Rexford74 , is this issue available to work on? |
Hello @Rexford74 Any updates on how should i proceed with this issue. |
@Rexford74 @Aryakoste Let's make sure to discuss this in Monday's websites call. |
Current Behavior
There is no page for Modal in Sistent
Desired Behavior
Implement the modal page using this Figma mockup
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.Join the Layer5 Community by submitting your community member form.
The text was updated successfully, but these errors were encountered: