Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update regex to support x formerly twitter urls #5478

Merged
merged 1 commit into from Apr 3, 2024

Conversation

vishalvivekm
Copy link
Member

Description

This PR fixes #5477

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 3, 2024

🚀 Preview for commit 9c51c77 at: https://660dcb92b0d0ef53f7684058--layer5.netlify.app

@vishalvivekm
Copy link
Member Author

@Yashsharma1911

After the renaming of Twitter to X, the profile links now start with ‘x.com’ when you try to enter that in the form, it shows invalid.

As this mentioned bug will result in newcomers filling out the form without entering their Twitter profile, I'm merging this fix rn.
About #5477 (comment):

The profile picture component is a text input and should be changed to an upload component.

This will need us to make some changes here and there in our flows.

@vishalvivekm vishalvivekm merged commit b9dbbf9 into master Apr 3, 2024
4 checks passed
@vishalvivekm vishalvivekm deleted the vishalvivekm/patch-1 branch April 3, 2024 21:38
@Yashsharma1911
Copy link
Member

Thankyou @vishalvivekm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The community onboarding form has bugs on the profile picture and twitter profile section.
3 participants