Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix Post Blog] - Demistifying Open Source #5447

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[Fix Post Blog] - Demistifying Open Source #5447

wants to merge 15 commits into from

Conversation

sandramsc
Copy link
Member

Description

This PR fixes #5446

Signed commits

  • Yes, I signed my commits.

@sandramsc
Create index.mdx
6b7dd82 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Add tech stack img
eab0619 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Upload blog images
48cfb26 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Add search Layer5 Five
635c97e 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Added all blog sections
a69536a 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Added final images
1c79871 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@github-actions github-actions bot added the area/blog New posts or new blog functionality label Mar 10, 2024
@vishalvivekm
Copy link
Member

build failing...

vishalvivekm
vishalvivekm requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please consider renaming the directory from Demystifying Open Source to demystifying-open-source

@sandramsc
Copy link
Member Author

@vishalvivekm Regarding points above, this PR is in draft mode and not ready for review yet, thanks.

@l5io
Copy link
Contributor

l5io commented Mar 13, 2024

🚀 Preview for commit e0e645a at: https://65f1aa2d3e64391fa5b71b35--layer5.netlify.app

@sandramsc
Fix linking by adding gatspy import, removed h2 tag reference
df36b22 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@l5io
Copy link
Contributor

l5io commented Mar 13, 2024

🚀 Preview for commit df36b22 at: https://65f1becc5b8293312897488f--layer5.netlify.app

@leecalcote
Delete src/collections/blog/2024/demystifying-open-source/banner.png:…
bf68d63 
…Zone.Identifier

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@l5io
Copy link
Contributor

l5io commented Mar 13, 2024

🚀 Preview for commit bf68d63 at: https://65f1c802db39543babe16f50--layer5.netlify.app

@sandramsc
Changed links to a tags, removed Link import
9198225 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@l5io
Copy link
Contributor

l5io commented Mar 14, 2024

🚀 Preview for commit 9198225 at: https://65f2d8477ef5a9b59a42117e--layer5.netlify.app

@sandramsc
Adjusted image height and width, fixed typo's
ce8ddc3 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Fix merge conflict
d75ea6a 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc
Fix syntax errors
2177f9a 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@l5io
Copy link
Contributor

l5io commented Mar 15, 2024

🚀 Preview for commit 2177f9a at: https://65f39e7b7ef5a9564141fd86--layer5.netlify.app

@sandramsc
Adjusted Five mascot on skateboard image size, making it smaller
289e9f4 
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@sandramsc sandramsc marked this pull request as ready for review March 15, 2024 01:28
@l5io
Copy link
Contributor

l5io commented Mar 15, 2024

🚀 Preview for commit 289e9f4 at: https://65f3a6ea0171f35e1d92aeec--layer5.netlify.app

@vishalvivekm
Copy link
Member

@sandramsc Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

iArchitSharma
iArchitSharma requested changes Mar 29, 2024
View reviewed changes
package-lock.json
@@ -7652,25 +7652,6 @@
"lodash.uniq": "^4.5.0"
}
},
"node_modules/caniuse-lite": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sandramsc , can you please revert this file??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma just so I understand the request, you mean to remove it yes?

@sudhanshutech
Copy link
Member

yes @sandramsc remove any changes from package file until there is no change in packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iArchitSharma iArchitSharma iArchitSharma requested changes

@leecalcote leecalcote Awaiting requested review from leecalcote

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Assignees
No one assigned
Labels
area/blog New posts or new blog functionality pr/do-not-merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Post Blog] - Demistifying Open Source
6 participants
@sandramsc @vishalvivekm @l5io @sudhanshutech @iArchitSharma @leecalcote