Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In devices width<1100 links of the verticle navbar are not behaving as expected #5389

Closed
Manishch27 opened this issue Feb 11, 2024 · 12 comments
Labels
kind/bug Something isn't working

Comments

@Manishch27
Copy link
Contributor

Manishch27 commented Feb 11, 2024

Description

In small devices width<1100px in the verticle navBar when we click on any link it covers the whole list and a blue layer is there on the whole content.

Expected Behavior

Only the content should be clickable and also there should not be any blue layer on the content.

Screenshots

WhatsApp.Video.2024-02-12.at.02.54.15.mp4

Environment:

  • Host OS: Android
  • Browser: Chrome

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Manishch27 Manishch27 added the kind/bug Something isn't working label Feb 11, 2024
@Manishch27
Copy link
Contributor Author

I would like to work on this issue.

@Manishch27 Manishch27 changed the title In devices width<1100 links of the verticle navbar are not behave as expected In devices width<1100 links of the verticle navbar are not behaving as expected Feb 11, 2024
@Ashparshp
Copy link
Contributor

Thanks for flagging. It might be a design choice rather than a bug. Appreciate your feedback, @saurabh100ni. Right?

@myselfprincee
Copy link

I feel it is not a bug but when ever you build a website and use it in your phone, it is a native style The Browser provides there's a css class to remove it

A single line and it will be fixed.

@Ashparshp
Copy link
Contributor

@myselfprincee But it provides better feedback to the user whenever get clicked..

@myselfprincee
Copy link

@myselfprincee But it provides better feedback to the user whenever get clicked..

Yes for sure

@Ashparshp
Copy link
Contributor

@saurabh100ni, it seems this issue may not be valid. Can we close it?

@leecalcote
Copy link
Member

@Manishch27, thanks for raising this concern. I fail to see where there's a blue layer. Could you help me understand the issue that you're describing a bit more? At the moment, it's not clear that there's sufficient evidence to warrant action here (that the behavior shown in the screen recording is a bug).

@vishalvivekm
Copy link
Member

@Manishch27, thanks for raising this concern. I fail to see where there's a blue layer. Could you help me understand the issue that you're describing a bit more? At the moment, it's not clear that there's sufficient evidence to warrant action here (that the behavior shown in the screen recording is a bug).

@Manishch27 thoughts??

@Manishch27
Copy link
Contributor Author

Manishch27 commented Feb 23, 2024

@leecalcote I agree with @myselfprincee and @Ashparshp it's not a bug it's a design choice and I apologize for the wrong label, but I don't find any label related to the design. When we open the layer5 website on the phone and click on any of the navigation links from the verticle navBar a blue layer appears on the top of the clicked link for a faction of seconds, it's a default styling provided by the browser for the links, but we can correct it with the help of CSS for the better user interface. @leecalcote attachment helps you to understand the issue better with current behavior and expected behavior.

Blue.Layer.-.Made.with.Clipchamp.mp4

@Ashparshp
Copy link
Contributor

If this isn't considered an issue, shall we close it? @vishalvivekm @Manishch27

@myselfprincee
Copy link

I think we should

@Ashparshp
Copy link
Contributor

Thanks, @myselfprincee. Closing this issue as it's deemed invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

No branches or pull requests

5 participants