lftp_ssl: deinitialize the lftp_ssl_openssl_instance #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the instance isn't deinitialized prior to exit, the OPENSSL_cleanup exit handler may run before the lftp_ssl_openssl_instance destructor on exit resulting in a segfault. This fixes a null deref on exit. Fixes lavv17#716
lavv17
reviewed
Jan 31, 2024
| @@ -863,6 +863,7 @@ lftp_ssl_openssl::~lftp_ssl_openssl() | |||
| { | |||
| SSL_free(ssl); | |||
| ssl=0; | |||
| global_deinit(); | |||
There was a problem hiding this comment.
I don't think we need to deinit the whole openssl every time a connection is closed. A better solution is needed.
There was a problem hiding this comment.
It just needs to be done before exit. Can you suggest a better location?
There was a problem hiding this comment.
I think OpenSSL clean up can be skipped altogether, it is not strictly required.
There was a problem hiding this comment.
It may not be strictly required, but the documentation does not suggest it is optional.
From
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_init_crypto.html
OPENSSL_INIT_NO_ATEXIT
By default OpenSSL will attempt to clean itself up when the process exits via an "atexit" handler. Using this option suppresses that behaviour. This means that the application will have to clean up OpenSSL explicitly using OPENSSL_cleanup().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the instance isn't deinitialized prior to exit, the OPENSSL_cleanup exit handler may run before the
lftp_ssl_openssl_instance destructor on exit resulting in a segfault.
This fixes a null deref on exit.
Fixes #716