Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

反馈:v2/advanced/core-api.md #40

Open
goldlin opened this issue Apr 2, 2019 · 0 comments
Open

反馈:v2/advanced/core-api.md #40

goldlin opened this issue Apr 2, 2019 · 0 comments

Comments

@goldlin
Copy link

goldlin commented Apr 2, 2019

core 的 koaMiddleware 代码是按照一次性执行写的,直接操作了 core 的 internalMiddleware,重复执行会重复打包之前的和新增的所有内部中间件

文档中的替换ssr中间件的写法虽然实际运行时不会出错,但事实上把除 ssr 和 error 之外的内部中间件都执行了两遍

不知道是代码打了文档的脸,还是反过来,反正对用户的误导很严重

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant