Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages support #29

Open
bsde1234 opened this issue May 4, 2019 · 3 comments
Open

gh-pages support #29

bsde1234 opened this issue May 4, 2019 · 3 comments

Comments

@bsde1234
Copy link

bsde1234 commented May 4, 2019

Will this gem support gh-pages hosting? Thanks.

@torrocus
Copy link

torrocus commented May 9, 2019

In README.md @xiaoiver wrote that:
"This plugin has been used in my blog so that you can see the effect."

At his page PWA works correctly and in Gemfile he uses github-pages.

So theoretically everything works.
But looking at the code of his site I have no idea how.
He has two branches master and gh-pages and I don't know which one is displayed on xiaoiver.github.io.
In my opinion, he doesn't use anywhere jekyll-pwa plugin.
There is no proper configuration in the _config.yml file.

@souldanger
Copy link
Collaborator

it works on gh-pages - see https://xiaoiver.github.io - which is obviously a GitHub domain...

@bsde1245
Copy link

He may be hosting in gh-pages, but deployed somewhere else like heroku. I think it won't work in gh-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants