Fix: subthreshold dynamics equation of refractory lif #842
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkin77
force-pushed
the
fix/lifRefractoryDynamics
branch
from
12fcbcb
to
89c2764
Compare
|
Hi, just to support this, in the Brian2Lava project we have used the same fix and it works well. |
monkin77
force-pushed
the
fix/lifRefractoryDynamics
branch
from
89c2764
to
765ede9
Compare
monkin77
force-pushed
the
fix/lifRefractoryDynamics
branch
from
765ede9
to
49c76b2
Compare
PhilippPlank
approved these changes
Apr 25, 2024
monkin77
force-pushed
the
fix/lifRefractoryDynamics
branch
from
a933bc0
to
1904854
Compare
monkin77
force-pushed
the
fix/lifRefractoryDynamics
branch
from
1904854
to
7bb6386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #841
Objective of pull request: Fix the
PyLifRefractoryModelFloatvoltage dynamics.Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
PyLifRefractoryModelFloatmodel does not update the voltage correctly in its sub-threshold dynamics. The current equation is:Therefore, the voltage of the neurons is updated incorrectly.
What is the new behavior?
so the new behavior uses this new equation.
Does this introduce a breaking change?
Supplemental information
The unit test related to the Refractory model confirmed that the voltage remains at 0 during the refractory state. However, the expected voltage array is incorrect, so it was also modified.
Closes #841