Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #38

Open
lathonez opened this issue Mar 9, 2016 · 18 comments
Open

Roadmap #38

lathonez opened this issue Mar 9, 2016 · 18 comments

Comments

@lathonez
Copy link
Owner Author

lathonez commented Mar 9, 2016

@marcmeans - FYI

@lathonez
Copy link
Owner Author

lathonez commented Mar 9, 2016

Linting

tslint should work out of the box if you have a tslint.json. If you would like further enhancements to linting please raise an issue and explain there.

@lathonez
Copy link
Owner Author

lathonez commented Mar 9, 2016

Testing with watches

Was implemented in #19. Explained in the blog and readme. If you would like further enhancements to this please raise an issue and explain there.

@lathonez
Copy link
Owner Author

lathonez commented Mar 9, 2016

examples of tests mocking observables/promises

I don't want this repo to turn into a "how to unit test" thing. It's a rabbit hole and I don't have the time or inclination to support it.

That being said there are certain things that I think are worth including, for example, testing Ionic @Pages using angular2 dependency injection, which is not done yet - though components are.

The best place for general unit testing questions probably stack overflow. There is an example with promises in clickers.spec.ts (most of the complex examples are therein).

@lathonez
Copy link
Owner Author

lathonez commented Mar 9, 2016

put example code in module structure for easy removal and showing pattern

@marcmeans - sounds interesting, but I don't know what you mean? Maybe raise an issue with some explanation?

@geoHeil
Copy link

geoHeil commented Jun 16, 2016

What about Hot Module Replacement?

@lathonez
Copy link
Owner Author

lathonez commented Jun 18, 2016

@geoHeil are you suggesting a move back to webpack (wouldn't happen unless Ionic went back again), or using browserify-hmr?

or something else?

@geoHeil
Copy link

geoHeil commented Jun 18, 2016

Not sure about implementation details, just saying HMR would be cool. As such browserify-hmr seems to be fine.

@lathonez
Copy link
Owner Author

just saying HMR would be cool

agreed

@ddellamico
Copy link

In this post, seems Ionic team are migrating again from Browserify to Webpack 2 to take advantage of "tree shaking." .. It would be nice start moving this project to webpack.. what do you think ?

@lathonez
Copy link
Owner Author

Yeah, if they do end up going with webpack2 in beta12 we'll switch over as
part of incorporating that upgrade into this repo.

I don't think it's worth doing ahead of time.

On 13 Aug 2016 02:44, "Damien" notifications@github.com wrote:

In this post http://blog.ionic.io/announcing-ionic-2-beta-11/, seems
Ionic team are migrating again from Browserify to Webpack 2 to take
advantage of "tree shaking." .. It would be nice start moving this project
to webpack.. what do you think ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#38 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5tSHHF88L9uMX8Eu6Btm0xCshvzM79ks5qfKLUgaJpZM4Hsebj
.

@marcoturi
Copy link

marcoturi commented Sep 1, 2016

Would be good to have same code documentation, maybe through typedoc ?

@lathonez
Copy link
Owner Author

lathonez commented Sep 1, 2016

@marcoturi - agreed. I've opened #139.

If you're feeling generous, a small PR would be fantastic.

If not thanks a lot for the suggestion, will do my best get round to it!

@captaincole
Copy link

@lathonez Have you put any thought into doing e2e testing on actual devices or through an emulator?

@lathonez
Copy link
Owner Author

#52 (top of the list). Last time I looked SauceLabs was the best option for FOSS.

Realistically I don't have any time for moving this roadmap forward (until my associated closed source project requires it).

Very happy for PRs / discussion suggestions around the correct direction.

@captaincole
Copy link

Ah it was hidden in the name. Yeah I'm currently checking out both a SauceLabs solution and Appium.

@lathonez
Copy link
Owner Author

If you come up with something that works let us know, maybe share config.

Thanks

@lathonez
Copy link
Owner Author

Now we're using @angular/cli, anything in the test direction should be raised upstream there. We'll take any features they add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants