Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l3doc doesn't make "TF" grey when documenting internal conditionals #730

Closed
joulev opened this issue May 26, 2020 · 2 comments · Fixed by #1470
Closed

l3doc doesn't make "TF" grey when documenting internal conditionals #730

joulev opened this issue May 26, 2020 · 2 comments · Fixed by #1470
Assignees
Labels
enhancement New feature or request l3doc

Comments

@joulev
Copy link

joulev commented May 26, 2020

MWE

% \iffalse
%<*driver>
\documentclass{l3doc}
\begin{document}
\DocInput{\jobname.dtx}
\end{document}
%</driver>
% \fi
% \begin{implementation}
%    \begin{macrocode}
%<@@=testpkg>
%<*package>
%    \end{macrocode}
% \begin{macro}[TF]{\@@_true:}
% This function is interesting.
%    \begin{macrocode}
\prg_new_conditional:Nnn \@@_true: { T, F, TF }
  { \prg_return_true: }
%    \end{macrocode}
% \end{macro}
%    \begin{macrocode}
%</package>
%    \end{macrocode}
% \end{implementation}

image

"TF" should be gray, shouldn't it?

@PhelypeOleinik PhelypeOleinik added enhancement New feature or request l3doc labels May 26, 2020
@PhelypeOleinik PhelypeOleinik self-assigned this May 26, 2020
@PhelypeOleinik
Copy link
Member

The TF is typeset by \@@_typeset_TF:, which adds an explicit \color{black}. Indeed it would probably look better if it was grey too.

@blefloch blefloch self-assigned this Apr 25, 2021
muzimuzhi added a commit to muzimuzhi/latex3 that referenced this issue Feb 23, 2024
muzimuzhi added a commit to muzimuzhi/latex3 that referenced this issue Feb 23, 2024
@muzimuzhi
Copy link
Contributor

FYI, the \color{black} and \color{red} in \@@_typeset_TF: were both added in a87b887 (add documentation for "restricted expandable" functions, 2011-09-04).

latex3/l3kernel/l3doc.dtx

Lines 2124 to 2138 in 46c6191

\cs_new_protected:Npn \@@_typeset_TF:
{
\cs_if_exist:NTF \Codedoc@explTF
{ \hyperlink { explTF } }
{ \mbox }
{
\color{black}
\itshape TF
\makebox[0pt][r]
{
\cs_if_exist:NT \Codedoc@explTF { \color{red} }
\underline { \phantom{\itshape TF} \kern-0.1em }
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request l3doc
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants