if statement into workflow

[AnassSamaa]

Hi, i want to know if it is advisable to use if statement into the workflow, i have tried it and it seems like sometimes it is working and sometimes it doesn't. In my case i put the if at the start of the workflow with the condition that if the signal become true the workflows has to end (I' am using an awaitWithTimeout), but sometime even if the signal is changed to true the if statement get ignored and the workflow keep going.

[rmcdaniel]

Can you share your workflow code please?

[AnassSamaa]

class TicketNotAssignedWarningWorkflow extends EscalationWorkflow
{
    private bool $assigned = false;

    /**
     * @return void
     */
    #[SignalMethod]
    public function setAssigned(bool $status)
    {
        $this->assigned = $status;
    }

    /**
     * @throws ReflectionException
     */
    public function execute(?Ticket $ticket): Generator
    {
        if ($ticket === null || $this->assigned) {
            return;
        }

        yield WorkflowStub::awaitWithTimeout(
            5*24*3600,
            fn () => $this->assigned);

        yield ActivityStub::make(
            SendTicketNotificationActivity::class,
            $ticket,
        );
    }
}

if i put before the if and before the awaitWithTimeout a dump($this->assigned), when the signal is changed sometimes it gives true on the first dump and then the workflow stops, other times it give false on the first dump and true on the second.

[rmcdaniel]

You should only check $this->assigned or any other signal after you await or awaitWithTimeout on it. Otherwise you will see the issue where the timing of the signal matters.

[rmcdaniel]

Also be aware that if you log inside a workflow execute method it will sometimes be confusing because it executes the same line multiple times as it loads and unloads between activities.