agent_registration uses 'recipe' instead of 'recipes' in search

[odyssey4me]

I've used a role to assign the zabbix::server, zabbix::web, zabbix and zabbix::agent_registration recipes to a server. The agent registration doesn't work because it uses 'recipe' instead of 'recipes' in the search. This means that it'll never work unless the recipe is directly assigned to the server, which is not ideal.

[laradji]

Yes it is it's in the attribute file
default['zabbix']['web']['fqdn'] = node['fqdn']

I think we need to remove this in the web.rb recipe :
node.normal['zabbix']['web']['fqdn'] = node['fqdn'] if node['zabbix']['web']['fqdn'].nil?

It make no sense and i hate to push attr to node when attribute file can do the job.

[laradji]

@guilhem what do you think ? i want a +1 :)

[odyssey4me]

@laradji whoops - I changed the topic of the issue without seeing that you had replied. ;)

With regards to the attribute - it should be set in the web default attribute file, not the common default attribute file. I'll give that a 👍

In fact, this is already raised in #141

[guilhem]

Yes we have to do like say in #141 :)

here is an example: https://github.com/ceph/ceph-cookbooks/blob/master/recipes/mon.rb#L22