Refactor: Split index.js into modular components #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract JXAExecutor utility class for script execution - Extract BuildLogParser utility for log parsing and derived data handling - Extract PathValidator utility for project/file path validation - Extract BuildTools class for build, clean, test, run, debug operations - Extract ProjectTools class for project operations (open, schemes, destinations) - Extract InfoTools class for workspace and project info operations - Create XcodeServer main class with tool registration and MCP handlers - Update index.js to be a simple entry point extending XcodeServer - Maintain backward compatibility with all existing method signatures - All critical tests passing (parameter validation, functionality) This refactoring improves code organization, maintainability, and testability by separating concerns into focused, single-responsibility modules. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This temporary file is no longer needed after the refactoring is complete. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ect matching Replaces name-based matching with exact WorkspacePath verification to ensure correct DerivedData folder selection when multiple projects have similar names. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Changes timeout from 3 minutes to 30 minutes to accommodate large projects that require more time to generate initial build logs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the monolithic
index.jsfile (1195 lines) into 8 focused, modular components:New Structure
index.js- Entry point (19 lines vs 1195 originally)src/XcodeServer.js- Main server class with tool registration and MCP handlerssrc/tools/BuildTools.js- Build, clean, test, run, debug, stop methodssrc/tools/ProjectTools.js- Open project, get schemes, set active scheme, get destinationssrc/tools/InfoTools.js- Get workspace info, get projects, open filesrc/utils/JXAExecutor.js- JXA script execution logicsrc/utils/BuildLogParser.js- Build log parsing, derived data handling, xcactivitylog parsingsrc/utils/PathValidator.js- Project and file path validation logicKey Benefits
✅ Improved Maintainability - Single responsibility per file
✅ Better Code Organization - Logical separation of concerns
✅ Enhanced Testability - Individual components can be tested in isolation
✅ Backward Compatibility - All existing method signatures preserved
✅ Easier Navigation - Developers can quickly find relevant code
Test Status
Test plan
The refactoring maintains 100% backward compatibility while significantly improving code organization and maintainability.
🤖 Generated with Claude Code