Data log "full" marker is not being written to interface storage

[microbit-carlos]

Running this programme on tag v0.2.63, which writes to the data log one byte at a time until the log is full:

#include "MicroBit.h"

MicroBit uBit;

int main() {
    uBit.init();

    uBit.display.print("?");

    while (true) {
        uBit.log.logString("X");
        uBit.sleep(1);

        if (uBit.log.isFull()) {
            uBit.display.print("D");
            uBit.sleep(100);
        }
    }
}

MICROBIT.hex.zip

We should expect the last 4 bytes, which are reserved for this marker, to contain FULL:

codal-microbit-v2/source/MicroBitLog.cpp

Line 258 in d54ce9b

logEnd = flash.getFlashEnd() - sizeof(uint32_t);

codal-microbit-v2/source/MicroBitLog.cpp

Lines 738 to 742 in d54ce9b

	if (!(status & MICROBIT_LOG_STATUS_FULL))
	{
	cache.write(logEnd+1, "FUL", 3);
	status |= MICROBIT_LOG_STATUS_FULL;
	}

However, the last 4 bytes are left untouched: MY_DATA.HTM.txt

[jaustin]

This is odd - do you know whether the byte-by-byte case ever wrote 'log full'? Does it still work if logging longer lengths? From MakeCode?

[microbit-carlos]

It must have worked at some point, as I believe that's how the "log full" message is meant to be displayed:

• Feature: Improve log size indicator #140

I haven't tried it in MakeCode yet.