Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break introduced with 2.7 ? #3

Open
weierophinney opened this issue Dec 31, 2019 · 2 comments
Open

BC break introduced with 2.7 ? #3

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

Seems like 2.7 introduced BC breaks. We experiences a failure (Public key not found) with updating from 2.6 to 2.7.
Basically we had in our composer.json:

"zendframework/zend-captcha": "^2.6",
"zendframework/zendservice-recaptcha": "^2.0.1",

We switched back to 2.6 for now until we make sure we can go ahead with zendservice-recaptcha v3.


Originally posted by @mheki at zendframework/zend-captcha#34

@weierophinney
Copy link
Member Author

@mheki an example failure would help


Originally posted by @Ocramius at zendframework/zend-captcha#34 (comment)

@weierophinney
Copy link
Member Author

@Ocramius I debugged further. We got this exception:

ZendService\ReCaptcha\Exception: Missing public key in C:\Apache24\htdocs\www\vendor\zendframework\zendservice-recaptcha\library\ZendService\ReCaptcha\ReCaptcha.php on line 380

because of:
v2.6: https://github.com/zendframework/zend-captcha/blob/release-2.6.0/src/ReCaptcha.php#L129-L134
vs v2.7
https://github.com/zendframework/zend-captcha/blob/release-2.7.0/src/ReCaptcha.php#L167-L180

We've been passing $options['private_key' => ..., 'public_key' => ...] obviously.


Originally posted by @mheki at zendframework/zend-captcha#34 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant