Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization in KimchiPartialVerifier.sol #229

Open
pablodeymo opened this issue Apr 30, 2024 · 0 comments
Open

Optimization in KimchiPartialVerifier.sol #229

pablodeymo opened this issue Apr 30, 2024 · 0 comments

Comments

@pablodeymo
Copy link
Contributor

We don't need to call a msm nor to allocate vectors. We can just do a scalar_mul here:

BN254.G1Point[] memory commitments = new BN254.G1Point[](1);
commitments[0] = verifier_index.sigma_comm[PERMUTS - 1];
Scalar.FE[] memory scalars = new Scalar.FE[](1);
scalars[0] = perm_scalars(evals, oracles.beta, oracles.gamma, alphas, permutation_vanishing_polynomial);
BN254.G1Point memory f_comm = Commitment.msm(commitments, scalars);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant