Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move subscription of operations to OperationsCollector #1048

Closed
mpaulucci opened this issue Apr 26, 2024 · 0 comments · Fixed by #1052
Closed

Move subscription of operations to OperationsCollector #1048

mpaulucci opened this issue Apr 26, 2024 · 0 comments · Fixed by #1052
Assignees
@avilagaston9
Labels
refactor Ideas to improve code usability or performance with little or no change to behavior

Comments

@mpaulucci
Copy link
Collaborator

We want https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/lib/lambda_ethereum_consensus/p2p/gossip/operations_collector.ex to subscribe to the appropriate topics and listen to {:gossipsub directly.

We should be able to remove these files afterwards:
https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/lib/lambda_ethereum_consensus/p2p/gossip/gossipsub.ex
https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/lib/lambda_ethereum_consensus/p2p/gossip/consumer.ex
https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/lib/lambda_ethereum_consensus/p2p/gossip/handler.ex
@mpaulucci mpaulucci added the refactor Ideas to improve code usability or performance with little or no change to behavior label Apr 26, 2024
@MegaRedHand MegaRedHand changed the title Move subscribtion of operations to operations collector Move subscription of operations to operations collector Apr 26, 2024
@MegaRedHand MegaRedHand changed the title Move subscription of operations to operations collector Move subscription of operations to OperationsCollector Apr 26, 2024
@avilagaston9 avilagaston9 mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avilagaston9 avilagaston9

Labels
refactor Ideas to improve code usability or performance with little or no change to behavior
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move subscriptions directly to operations_collector lambdaclass/lambda_ethereum_consensus
2 participants
@mpaulucci @avilagaston9