Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests run without --no-start #1036

Open
Arkenan opened this issue Apr 25, 2024 · 0 comments
Open

Make tests run without --no-start #1036

Arkenan opened this issue Apr 25, 2024 · 0 comments

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Apr 25, 2024

Currently we have different configuration categories:

  • mode: db vs full. :db doesn't enable the metadata genserver, the beacon api or the beacon node, which contains the fork choice genserver, libp2p features, the beacon chain genserver, etc.
  • genesis_strategy: were to get the first state from: checkpoint sync, a .ssz file, or the db.

Unit tests are mostly functional, and run with --no-start, so they currently patch interactions with the beacon chain so that libp2p doesn't activate, sync with others in a public network, etc. However, the client is configurable enough for us to be able to run the actual node in the tests and avoid patching and mocking behavior. In that way we both should increase coverage and stop hiding errors in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant