Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Depends on tagged hdrs instead #268

Open
Xuanwo opened this issue Jul 11, 2023 · 2 comments
Open

proposal: Depends on tagged hdrs instead #268

Xuanwo opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Xuanwo
Copy link

Xuanwo commented Jul 11, 2023

Hi, I'm the maintainer of hdrs. Thank you for choosing hdrs as your client to connect with HDFS! I have noticed that LakeSoul is using a fork of hdrs.

Would you like to switch to the tagged version of hdrs? I am willing to review pull requests and release a new version if necessary.

@xuchen-plus xuchen-plus self-assigned this Jul 11, 2023
@xuchen-plus xuchen-plus added the dependencies Pull requests that update a dependency file label Jul 11, 2023
@xuchen-plus
Copy link
Contributor

Hi, thanks for creating the hdrs project and the advice.

Previously we forked hdfs-sys and hdrs to fix compilation problems on Windows platform (see lakesoul-io/hdrs@5b92799 and lakesoul-io/hdfs-sys@15d765e) because some users need them to run some tests on Windows.

I will find some time to push the patches to upstream so that we can switch to a new release version.

@Xuanwo
Copy link
Author

Xuanwo commented Jul 11, 2023

Great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: No status
Development

No branches or pull requests

2 participants