Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Mode tests #45

Open
TimMoore opened this issue May 22, 2019 · 3 comments
Open

Dev Mode tests #45

TimMoore opened this issue May 22, 2019 · 3 comments

Comments

@TimMoore
Copy link

Currently, the gRPC example projects don't run in dev mode due to lagom/lagom#1857.

It would be nice if we could catch this in CI. I'm opening this issue to start a discussion with the team about how we might be able to do this, and whether it would be worthwhile. I guess we'd need to add scripted tests, which could inflate the build times a lot. Maybe as a nightly job?

@TimMoore
Copy link
Author

We'd want the scripted tests to roughly mirror the instructions we provide in the read-me files for each example. Otherwise, we would need to manually run through the instructions for QA on any significant change.

@ignasi35
Copy link
Contributor

IMHO, this issue surfaces in lagom/lagom-samples but it should be caught in either lagom/lagom or playframework/play-grpc .

@TimMoore
Copy link
Author

For the specific gRPC/Akka Discovery problem, I agree, but the reason I raised this issue separately is because some kind of testing of the user experience of the samples would be good to have in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants