Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use click plugins to import honeybee radiance into honeybee cli #150

Open
AntoineDao opened this issue Jun 10, 2020 · 2 comments
Open

Use click plugins to import honeybee radiance into honeybee cli #150

AntoineDao opened this issue Jun 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@AntoineDao
Copy link
Member

AntoineDao commented Jun 10, 2020

Change in 3c7e39f caused old CLI setup to break.

That changed somehow removed the radiance from the honeybee CLI in the docker container... 馃槩

Here's a demo of the previous version (1.19.8) working and the version this commit created (1.19.9) not working:

image

Further comments here.

@mostaphaRoudsari
Copy link
Member

@chriswmackey, can you take care of this or do you want me to do this? Here is an example for how you can set it up: https://github.com/ladybug-tools/queenbee-luigi/blob/a2c4dd7309e228334e6dd0b06ba37f4a5858ef1a/setup.py#L25-L28

@mostaphaRoudsari mostaphaRoudsari self-assigned this Jul 3, 2020
@mostaphaRoudsari mostaphaRoudsari added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 3, 2020
@mostaphaRoudsari
Copy link
Member

I remembered what was going on here. For now honeybee-radiance command will still work. We can use click plugins but that means making changes in honeybee cli and then adding it to radiance and energy extension. It's not hard to do but it takes time and is not critical at this point.

@mostaphaRoudsari mostaphaRoudsari removed their assignment Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants