Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic interface to uff in pyEMA #26

Open
nilswagner opened this issue Jun 10, 2021 · 3 comments
Open

Automatic interface to uff in pyEMA #26

nilswagner opened this issue Jun 10, 2021 · 3 comments

Comments

@nilswagner
Copy link

An automatic interface to uff in pyEMA would be appreciated.
Until now you always need a second module, i.e. pyuff to import .unv/.uff files.
The different license types of pyEMA (MIT license) and pyuff (part of OpenMODAL (GPL)) make this difficult sometimes.

@jankoslavic
Copy link
Contributor

Dear @nilswagner This sounds like a good idea. Could you please elaborate a little more what functionality would you need. Maybe present a use case...

@nilswagner
Copy link
Author

I currently have three application scenarios in mind.
pyEMA offers a method (tools.py) to compute the MAC matrix. Therefore pyEMA should support datasets 15, 55, 82, 2411, 2412.
The second feature is the mode complexity #25 (polar plot visualization of complex modes and computation of MCF).
The third application is the mode estimation from FRFs. That means that we need a feature to import FRFs (dataset 58).

@klemengit
Copy link
Collaborator

Since the main task of pyEMA is to extract modal parameters from the FRFs, I think that it doesn't need the automatic importing/exporting from/to .uff. pyEMA is not meant to be an all-in-one application, but a building block for the user to include in the program. pyuff can therefore be used to import and export the data.

That being said, I do agree that the connectivity between pyEMA and pyuff should be improved.
Usage examples could be included in showcase and documentation. pyEMA could prepare the data to be saved in the .uff (dictionary); however, the user should use pyuff to save the data. When importing from .uff, a supporting function could be added to pyEMA to extract arguments for pyEMA.Model() from the pyuff.UFF() object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants