Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help-wanted/beginner-friendly] Link underlining runs through descenders #93

Open
vincent-io opened this issue Apr 18, 2015 · 3 comments

Comments

@vincent-io
Copy link

The link underlining is quite thick and runs through descenders (see Skype):
screen shot 2015-04-18 at 09 55 19

Perhaps a bottom border with less thickness would look better?

@lacymorrow
Copy link
Owner

Thanks for filing these! I used the original Casper CSS but they have made plenty of updates and there are definitely changes that need to be addressed in my version. I won't have lots of time for development so pull requests are welcome!

@paulovsky
Copy link
Contributor

paulovsky commented Aug 10, 2017

my solution, added to the css in my child theme:
/*nice links*/
.post-content a, #comments a {text-decoration: none; border-bottom: 1px solid; padding: 2px 1px 0;}

screenshot 2017-08-10 18 12 41

@lacymorrow
Copy link
Owner

That's great @paulovsky! Feel like submitting a PR? I'm happy to help you pull it in. I finally have time to update.

@lacymorrow lacymorrow changed the title Link underlining runs through descenders [help-wanted/beginner friendly] Link underlining runs through descenders Dec 13, 2017
@lacymorrow lacymorrow changed the title [help-wanted/beginner friendly] Link underlining runs through descenders [help-wanted/beginner-friendly] Link underlining runs through descenders Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants