Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The sealos run command parameter --env cannot read variables containing commas. #4662

Open
bxy4543 opened this issue Apr 7, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@bxy4543
Copy link
Member

bxy4543 commented Apr 7, 2024

Sealos Version

4.3, 5.0, main

How to reproduce the bug?

sealos run docker.io/labring/victoria-metrics-k8s-stack:v1.96.0 -e HELM_OPTS="--set grafana.enabled=false,vmsingle.enabled=false,vmcluster.enabled=true"
2024-04-07T08:28:08 info start to install app in this cluster
2024-04-07T08:28:08 info Executing SyncStatusAndCheck Pipeline in InstallProcessor
2024-04-07T08:28:08 info Executing ConfirmOverrideApps Pipeline in InstallProcessor
2024-04-07T08:28:08 info are you sure to override these following apps?
docker.io/labring/victoria-metrics-k8s-stack:v1.96.0
Yes [y/yes], No [n/no]: y
✔ Yes [y/yes], No [n/no]: y█
2024-04-07T08:28:10 info Executing pipeline MountRootfs in InstallProcessor.
2024-04-07T08:28:10 info Executing pipeline MirrorRegistry in InstallProcessor.
2024-04-07T08:28:10 info trying default http mode to sync images to hosts [192.168.0.55:22]
2024-04-07T08:28:12 info Executing UpgradeIfNeed Pipeline in InstallProcessor
bash: line 1: export: vmcluster.enabled=true': not a valid identifier bash: line 1: export: vmsingle.enabled=false': not a valid identifier

What is the expected behavior?

https://github.com/labring-actions/cluster-image/tree/main/applications/victoria-metrics-k8s-stack#configuration

-e HELM_OPTS="--set grafana.enabled=false,vmsingle.enabled=false,vmcluster.enabled=true" can be executed successfully.

What do you see instead?

  - cmd:
    - bash entrypoint.sh
    env:
      HELM_OPTS: --set grafana.enabled=false
      vmcluster.enabled: "true"
      vmsingle.enabled: "false"
    imageName: docker.io/labring/victoria-metrics-k8s-stack:v1.96.0

env parsing error, should be:
env: HELM_OPTS: --set grafana.enabled=false,vmcluster.enabled: "true",vmsingle.enabled: "false"

Operating environment

- Sealos version:
- Docker version:
- Kubernetes version:
- Operating system:
- Runtime environment:
- Cluster size:
- Additional information:

Additional information

No response

@bxy4543 bxy4543 added the kind/bug Something isn't working label Apr 7, 2024
@bxy4543
Copy link
Member Author

bxy4543 commented Apr 11, 2024

The execution of env can be read correctly:

sealos run -e HELM_OPTS="--set grafana.enabled=false --set vmsingle.enabled=false --set vmcluster.enabled=true" docker.io/labring/victoria-metrics-k8s-stack:v1.96.0

@bxy4543 bxy4543 changed the title BUG: The cluster image cannot be used correctly --env passed in the helm set parameter BUG: The sealos run command parameter --env cannot read variables containing commas. Apr 11, 2024
@willzhang
Copy link
Contributor

I have also encountered this issue, which can result in long commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants