Fix ONNX providers with SAM #1340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to change the providers to |
|
I try it but failed. Maybe we still need to check if CUDA is available, and then update the provider list. |
|
Adding the CUDA provider seemed to work fine for me. What's the best way to check for cuda within the dependencies of this repo? Normally I would just use |
|
Thanks for the report. Fixed via #1364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334
The latest version of
onnxruntime.InferenceSessionseems to requireprovidersare specified. This is a small patch that adds them in. I'm not sure if the values I specified were correct or optimal, but it allows SAM to work on my machine rather than crash.