Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/form modal #37

Merged
merged 45 commits into from
Mar 30, 2022
Merged

Feature/form modal #37

merged 45 commits into from
Mar 30, 2022

Conversation

l0fl0
Copy link
Owner

@l0fl0 l0fl0 commented Mar 16, 2022

A Large branch.

Covered a lot pertaining to styles.
(Notes, Tasks, Settings, Chat, Users)

Functionally
(Notes, Tasks, Settings)
fixed all buttonsin the notes and tasks apps, settings now works and saves state upon user input

@l0fl0
toolbar multiple title fix and styles update
dbd60d5
@l0fl0
fontawesome refactor and file name changes
59d9f0b
@l0fl0
added hover for icons and added new text color
9022cbe
@l0fl0
created functions partial for applying colors for frame backgrounds, …
b9db1e4 
…now in the variables partial the map of frame colors are stored
@l0fl0
new styles for chat app
f8bbf9e
@l0fl0
styled the icons using filter for svg styles
d8e9c77
@l0fl0
fixed edit still on after no tasks are rendered
d2c707f
@l0fl0
added more styles to chat componend and refactored the function to re…
091090d 
…nder different message layouts
@l0fl0
new styles for media player
5e5b4d7
@l0fl0
temporary comp to test modal frame
bd91f4e
@l0fl0
added modal frame functionality
a3444a9
@l0fl0
file cleanup and modal bg color
964767b
@l0fl0
added invisible scroll mixin and cleaned variables
b0cee79
@l0fl0
cleanning components
6d7adab
@l0fl0
testing the modal
0b2e12d
@l0fl0
refactor to addEditTask component and moved file
8fa16f9
@l0fl0
added new scss variable for backgrounds
c9632f2
@l0fl0
taking stab at modal popup but unsuccessful might use different metho…
cf42be8 
…d or consult daniel
@l0fl0
Daniel showed the way to add props to components
19d5f4e
@l0fl0
split notes componen / notes form
f545d36
@l0fl0
loading icons based off of icon classname in items.js
f6263ab
@l0fl0
fixing notes component to conform to the frames
09c799a
@l0fl0
fixed format date to display 12 instead of 00
dd63a51
@l0fl0
notes has add/edit and delete functionality
49a44da
@l0fl0
clean up files
f8039d3
@l0fl0
used modal frame to add new task
ffadca0
@l0fl0
added use effect for cleaner code
a64867a
@l0fl0
adding edit functionality to task modal but there is a bug with compo…
5087074 
…nent will update on tasks.jsx / added text to assist UX
@l0fl0
edit/add/delete fully functional, conformed styles between tasks and …
887dbe8 
…notes
@l0fl0
added support for on enter form submit
54a3308
l0fl0 added 12 commits March 14, 2022 15:23
@l0fl0
cleaned code to be more readable
5a45793
@l0fl0
conforming styles to tasks app
78f037a
@l0fl0
merge dev to form modal branch
3025b9d
@l0fl0
stored the socket tokens in an obj to store username and id
2ad0abd
@l0fl0
users app is temp styled and added TODO:/ fixed bug on notes mount
29d5579
@l0fl0
simplified the time format functions
8e6db9b
@l0fl0
styled toggle button, fixed settings functionality, cleaned up props …
faa6525 
…to pass from frame to frame
@l0fl0
time now dependant on global state and can be manipulated in the sett…
788bbd8 
…ings app
@l0fl0
cleaning up task component
0986d6f
@l0fl0
added global styles and applied them to apps
409b931
@l0fl0
updated meta tags to have clearer information (icons, Landing page im…
69634fa 
…age)
@l0fl0
updated README/.env.example and added settings to be the last icon on…
2a92053 
… the tool bar
@l0fl0 l0fl0 requested a review from danielstich March 16, 2022 17:34
@l0fl0 l0fl0 added bug Something isn't working enhancement New feature or request labels Mar 16, 2022
This was linked to issues Mar 16, 2022
Add edit button to notes/ tasks #11
Open
Font awesome update refactor needed #20
Open
Fixed Settings App #33
Open
danielstich
danielstich approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@danielstich danielstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude, looks good! Sorry for the delay!! Go ahead and merge this bad boy.

@l0fl0 l0fl0 merged commit 4a9c70e into develop Mar 30, 2022
@l0fl0 l0fl0 deleted the feature/form-modal branch March 30, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielstich danielstich danielstich approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
BrainStation Lounge
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed Settings App Font awesome update refactor needed Add edit button to notes/ tasks
2 participants
@l0fl0 @danielstich