-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Manifest Index to ImageRegistry context #9883
base: main
Are you sure you want to change the base?
feat: Add Manifest Index to ImageRegistry context #9883
Conversation
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
a4a8c2b
to
9dfdb0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see some test coverage for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests for both multiarch and singlearch image would be nice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9883 +/- ##
==========================================
- Coverage 33.60% 33.59% -0.01%
==========================================
Files 347 347
Lines 23843 23843
==========================================
- Hits 8013 8011 -2
- Misses 14941 14942 +1
- Partials 889 890 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Netanel Kadosh <kadoshnetanel@gmail.com>
9dfdb0c
to
cd813dd
Compare
@NetanelK are you planning to continue to work on this? Would be great to see this added. |
Explanation
This PR adds the missing OCI Image Index to
imageRegistry
context, it adds theimageIndex
field that contains the index.Image Index can be used to evaluate an image's supported platforms.
Related issue
Closes #8273 @chipzoller
Milestone of this PR
/milestone 1.13.0
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
imageIndex
field toimageData
website#1182What type of PR is this
/kind feature
Proposed Changes
Fetching
imageIndex
from image registry and output its raw JSON, same waymanifest
andconfig
are being handledProof Manifests
To test this PR, create
cpol.yaml
:create
pod.yaml
:create
patchedPod
:Test with
kyverno-cli
,kyverno-test.yaml
:Checklist
Further Comments