Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Enhanced Icon #161

Open
alabotski opened this issue Jun 20, 2023 · 12 comments
Open

Hide Enhanced Icon #161

alabotski opened this issue Jun 20, 2023 · 12 comments

Comments

@alabotski
Copy link

It was version 1.2.4.
This functionality worked.
4G+ was displayed instead of 4G.

Delivered version 1.2.6.
Plus is not displayed not for LTE, not for 4G.

With a plus, the icon is just more compact

The problem arose after I turned on and off the
Always Show Data RAT Icon (what is it option?)

(https://github.com/kyujin-cho/pixel-volte-patch/assets/439337/34f72687-e161-4f96-add2-cb25021a2214)

@arsradu
Copy link

arsradu commented Aug 21, 2023

It works fine for me. These are my settings.
Screenshot_20230822-000019
Screenshot_20230822-000034

@exolon
Copy link

exolon commented Aug 22, 2023

What does the RAT option do anyway?

@arsradu
Copy link

arsradu commented Aug 22, 2023

It shows the data icon (E/H+/4G etc) near your signal indicator even when mobile data is turned off.

It refers to this functionality from Android: https://developer.android.com/reference/android/telephony/CarrierConfigManager#KEY_ALWAYS_SHOW_DATA_RAT_ICON_BOOL

@exolon
Copy link

exolon commented Aug 22, 2023

It shows the data icon (E/H+/4G etc) near your signal indicator even when mobile data is turned off.

It refers to this functionality from Android: https://developer.android.com/reference/android/telephony/CarrierConfigManager#KEY_ALWAYS_SHOW_DATA_RAT_ICON_BOOL

Ahhh ok, thanks, wasn't seeing any difference but obviously I didn't pay close attention!

@alabotski
Copy link
Author

alabotski commented Aug 25, 2023

So my question
Which option I should enable (disable), so that 4g becomes 4g+. On the old version, I adjusted it "Hide enhanced icon"

Screenshot_20230825-161835
Screenshot_20230825-161851
Screenshot_20230825-161902

@arsradu
Copy link

arsradu commented Aug 25, 2023

The ones I checked/unchecked in my screenshots above.
Enable Enhanced LTE (LTE+) - checked
Show 4G for LTE Data Icon - checked
Hide Enhanced Data Icon - unchecked

4G+ will only be displayed IF the phone can actually do carrier aggregation, which is what the 4G+ is about.

@fillwithjoy1
Copy link
Contributor

What does the RAT option do anyway?

its an acronym for "radio access technology"
tl:dr your phone access data using radio technologies like 4g, 5g, etc., hence radio access technology or RAT.

@fillwithjoy1
Copy link
Contributor

So my question Which option I should enable (disable), so that 4g becomes 4g+. On the old version, I adjusted it "Hide enhanced icon"

Screenshot_20230825-161835 Screenshot_20230825-161851 Screenshot_20230825-161902

Is this a cosmetic issue?

@arsradu
Copy link

arsradu commented Feb 16, 2024

So my question Which option I should enable (disable), so that 4g becomes 4g+. On the old version, I adjusted it "Hide enhanced icon"
Screenshot_20230825-161835 Screenshot_20230825-161851 Screenshot_20230825-161902

Is this a cosmetic issue?

It's actually not an issue. The app behaves as it should. But yes, cosmetic. :)

@fillwithjoy1
Copy link
Contributor

So my question Which option I should enable (disable), so that 4g becomes 4g+. On the old version, I adjusted it "Hide enhanced icon"
Screenshot_20230825-161835 Screenshot_20230825-161851 Screenshot_20230825-161902

Is this a cosmetic issue?

It's actually not an issue. The app behaves as it should. But yes, cosmetic. :)

Well, in that case he should check out https://github.com/programminghoch10/MobileIconChanger for that

@arsradu
Copy link

arsradu commented Feb 16, 2024

So my question Which option I should enable (disable), so that 4g becomes 4g+. On the old version, I adjusted it "Hide enhanced icon"
Screenshot_20230825-161835 Screenshot_20230825-161851 Screenshot_20230825-161902

Is this a cosmetic issue?

It's actually not an issue. The app behaves as it should. But yes, cosmetic. :)

Well, in that case he should check out https://github.com/programminghoch10/MobileIconChanger for that

Looks like a cool app. Personally I don't need it, since the functionality I get with this app is perfectly fine for my needs, but good to know. Thanks!

@fillwithjoy1
Copy link
Contributor

@kyujin-cho asking to close this issue down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants