Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple goal patterns in verifier #6038

Open
nbeloglazov opened this issue Mar 4, 2024 · 0 comments
Open

Support multiple goal patterns in verifier #6038

nbeloglazov opened this issue Mar 4, 2024 · 0 comments
Labels
verifier Issues with the Kythe verifier

Comments

@nbeloglazov
Copy link
Collaborator

Verifier provides flag --goal_regex that allows for custom goal regexes. It works well for single languages, not so well for 2+ languages that have different style of comments. For example here is a regex that supports both //- goal and <!-- goal --> comments: \\s*(?:\\/\\/-|<!--)([^>]*)(?:-->)?$. It's pretty unreadable.

It would be good if we could pass multiple --goal_regex values and verifier will try them all. Or some other approach for providing 2+ different goal patterns.

@nbeloglazov nbeloglazov added the verifier Issues with the Kythe verifier label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifier Issues with the Kythe verifier
Projects
None yet
Development

No branches or pull requests

1 participant