Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref/call spans should cover identifiers only #5691

Open
zrlk opened this issue Jun 7, 2023 · 0 comments
Open

ref/call spans should cover identifiers only #5691

zrlk opened this issue Jun 7, 2023 · 0 comments
Assignees
Labels
schema Issues impacting the language neutral schema

Comments

@zrlk
Copy link
Contributor

zrlk commented Jun 7, 2023

Historically, the source anchor for ref/call covered the entire calling expression. Users generally disliked the resulting decorations and they were suppressed, as the ref to the callee was sufficient. To simplify the schema and make certain postprocessing tasks easier, the source anchor for a ref/call should be the same as the source anchor for that corresponding ref.

Syntactic forms that do not have an equivalent corresponding ref (e.g., implicit coercions) should maintain their existing behavior.

We do not currently propose dropping the ref as user code may rely on it, but expect to do so in the future.

@zrlk zrlk added the schema Issues impacting the language neutral schema label Jun 7, 2023
@zrlk zrlk self-assigned this Jun 9, 2023
zrlk added a commit to zrlk/kythe that referenced this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Issues impacting the language neutral schema
Projects
None yet
Development

No branches or pull requests

1 participant