Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ indexer depends on @rust_linux_x86_64//:rustc_lib #5371

Open
ivan444 opened this issue Aug 31, 2022 · 3 comments
Open

C++ indexer depends on @rust_linux_x86_64//:rustc_lib #5371

ivan444 opened this issue Aug 31, 2022 · 3 comments
Assignees

Comments

@ivan444
Copy link

ivan444 commented Aug 31, 2022

Hi!

Our CI (at https://github.com/chipsalliance/verible; Bazel based) is running Kythe C++ indexer to update our project at http://cs.opensource.google .

The CI downloads Kythe release and does Bazel build with extractors.bazelrc, which now fails as we hit runtime dependency on @rust_linux_x86_64//:rustc_lib.

Could you make that dependency optional? I.e. only when processing rust code?

Our workaround is to fork extractors.bazelrc and drop the languages we don't care about. Works, but it's a bit fragile.

@shahms
Copy link
Contributor

shahms commented Aug 31, 2022

Yes; the C++ indexer should not depend on Rust.

@shahms
Copy link
Contributor

shahms commented Aug 31, 2022

I think the issue may be that we just run build with all of the known extractors in extractrors.bazelrc

I'm not sure there's an easy way around that and may require a bit of work (if that's the cause)

@shahms shahms self-assigned this Aug 31, 2022
@ivan444
Copy link
Author

ivan444 commented Aug 31, 2022

Yep, the issue is that extractors.bazelrc adds all known extractors to build.

A simple solution is to change the instructions:

  • Create slimmer bazelrc (no language specific --experimental_action_listeners)
  • Tell people to manually add --experimental_action_listener= to their bazel invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants