Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double Socket Connect #45

Closed
kyle8998 opened this issue Mar 2, 2018 · 3 comments
Closed

Double Socket Connect #45

kyle8998 opened this issue Mar 2, 2018 · 3 comments
Assignees
@kyle8998
Labels
bug help wanted important
Projects
2.0
Milestone
2.0

Comments

@kyle8998
Copy link
Owner

kyle8998 commented Mar 2, 2018

For some reason, each client that joins the server connects as two separate sockets. This can impact some events that occur.
@kyle8998 kyle8998 added this to the 1.0 Public Release milestone Mar 2, 2018
@kyle8998 kyle8998 self-assigned this Mar 2, 2018
@kyle8998 kyle8998 added this to On-hold in Public Release 1.0 Mar 2, 2018
@kyle8998
Copy link
Owner Author

kyle8998 commented Mar 4, 2018

Seems to be a common issue with socket.io

socketio/socket.io#474

@kyle8998
Copy link
Owner Author

kyle8998 commented Mar 4, 2018

Was not fixed with

io.sockets.once('connection', function(socket) {}

@kyle8998 kyle8998 removed this from On-hold in Public Release 1.0 Jun 19, 2018
@kyle8998 kyle8998 modified the milestones: 1.0 Public Release, 2.0 Jun 19, 2018
@kyle8998 kyle8998 added this to On Hold in 2.0 Jun 19, 2018
kyle8998 added a commit that referenced this issue Jul 15, 2018
@kyle8998
Double Socket Fix (#45)
951a223 
So uh I was just connecting twice. Quite the embarassing fix, but at
least it's done now!
@kyle8998
Copy link
Owner Author

So I was just being silly with my 2 io.connect() calls...

951a223

@kyle8998 kyle8998 moved this from On Hold to Done in 2.0 Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyle8998 kyle8998

Labels
bug help wanted important
Projects
2.0
  
Done
Milestone
2.0
Development

No branches or pull requests
1 participant
@kyle8998