Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cons when using metric... #28

Open
Leiwx52 opened this issue Aug 16, 2020 · 3 comments · Fixed by #29
Open

Some cons when using metric... #28

Leiwx52 opened this issue Aug 16, 2020 · 3 comments · Fixed by #29
Labels
enhancement New feature or request

Comments

@Leiwx52
Copy link

Leiwx52 commented Aug 16, 2020

Hi, thank you for your contributions! I found this repo really easy to follow.

However, when I called mmc.metrics.evaluate to evaluate FID score, it turns out that the path to dataset is bound to './datasets', which might not be convenient if someone put their datasets out of the GAN project.

Also, would you mind providing some details of parameter combinations(i.e. batch_size, n_dis in training process and num_samples, num_real_samples and num_fake_samples in evaluating) by which the model can achieve the baseline's performance(IS, FID, KID)?

@kwotsin kwotsin added the enhancement New feature or request label Aug 16, 2020
@kwotsin kwotsin linked a pull request Aug 16, 2020 that will close this issue
@kwotsin
Copy link
Owner

kwotsin commented Aug 16, 2020

Hi @WingsleyLui , thanks for your kind comments! I also realised this from a similar issue #20 , and so added support for using custom datasets. In general, for using custom datasets, one only needs to implement a Dataset object and feed it into the dataset argument. I also added an example to see how to use the same with the evaluate API here: https://github.com/kwotsin/mimicry/blob/master/examples/eval_pretrained.py#L89-L99

Feel free to let me know your thoughts on this addition!

@Leiwx52
Copy link
Author

Leiwx52 commented Aug 17, 2020

@kwotsin Thank you for your response! This helps a lot!

Besides, are you going to implement the visualization of spectral norm, weight norm of each layer in training process with tensorboard? Also the largest singular value might helps to find out the mode collapse. Although this might be computationally expensive, I thought this might set to be an optional choice in implementation cuz a lot of researchers did this in their analysis section.

@kwotsin
Copy link
Owner

kwotsin commented Aug 18, 2020

@WingsleyLui Thanks for your suggestions, I will take a look at the SN visualisation as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants