Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSGAN missed Self-Modulation Normalization? #18

Open
shimopino opened this issue Jun 7, 2020 · 2 comments
Open

SSGAN missed Self-Modulation Normalization? #18

shimopino opened this issue Jun 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@shimopino
Copy link

Hi! Thank you for creating this easy-to-use library!

I was using your implementation of SSGAN to reproduce the original paper https://arxiv.org/abs/1810.01365.

As I read the original paper, the highest performing model was the one that used Self-Modulation Normalization, not Batch Normalization like your GBlock https://github.com/kwotsin/mimicry/blob/master/torch_mimicry/modules/resblocks.py#L73.

image

image

Do you have any plans to add Self-Modulation Normalization?

@kwotsin
Copy link
Owner

kwotsin commented Jun 7, 2020

Hi @KeisukeShimokawa, yes indeed I mostly compared to the version without sBN to keep the design simple as sBN is a general architectural improvement, but indeed it will be an interesting addition to have. Since it's suitable for most unconditional GAN I think it should be a good addition. Will keep this issue open and update in the future!

@kwotsin kwotsin added the enhancement New feature or request label Jun 7, 2020
@shimopino
Copy link
Author

Excellent! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants