Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis client does not expose property connected #204

Open
bjorndown opened this issue Apr 6, 2020 · 5 comments
Open

ioredis client does not expose property connected #204

bjorndown opened this issue Apr 6, 2020 · 5 comments

Comments

@bjorndown
Copy link

bjorndown commented Apr 6, 2020

We are trying to use apicache with an ioredis client, but we don't see any keys in redis. It seems that the check introduced with 375ccc7 does not work for ioredis because its client does not expose a connected property.

When I monkey-patch the connected property, I can see cache keys in redis.

ioredis sends connection events (https://github.com/luin/ioredis#connection-events).

@jackluo
Copy link

jackluo commented May 22, 2020

Second this issue

@neilhem
Copy link

neilhem commented Jun 11, 2020

Confirm, using ioredis as redis sentinel client do not save cached value to the Redis

@rosslavery
Copy link

Also experiencing this -- had to downgrade to 1.5.1 to fix it in the meantime.

@sidgujrathi
Copy link

Checked and confirmed with ^1.5.3, Second this issue 👍

@lukebelbina
Copy link

Confirmed that apicache was not working with ioredis for version 1.5.3, downgrading to 1.51 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants