Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the NativeHookThread deliberately NOT a daemon thread? #453

Open
cbbravo opened this issue Oct 25, 2023 · 1 comment
Open

Why is the NativeHookThread deliberately NOT a daemon thread? #453

cbbravo opened this issue Oct 25, 2023 · 1 comment

Comments

@cbbravo
Copy link

cbbravo commented Oct 25, 2023

Is there any reason this was made deliberately?

Or would it be acceptable to overload the GlobalScreen.registerNativeHook() method to accept a boolean parameter that gets passed on to NativeHookThread constructor and then to thread.setDaemon()?

@kwhat
Copy link
Owner

kwhat commented Oct 25, 2023

It was deliberate so that a registered hook wouldn't prevent a normal ui based app from existing without uninteresting first.

I believe the original idea was that you can extend the global screen and override whats needed. not sure how feasible that is at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants