Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fencing/enabled: false overwritten #11

Open
jsalatiel opened this issue Oct 31, 2020 · 1 comment
Open

fencing/enabled: false overwritten #11

jsalatiel opened this issue Oct 31, 2020 · 1 comment

Comments

@jsalatiel
Copy link

If I annotate the node with "fencing/enabled: false" I expect that fencing-switcher won't change it for true again, but apparently is does.
Is this the expected behaviour? How can i make sure some nodes will never be fenced ?

@kvaps
Copy link
Owner

kvaps commented Oct 31, 2020

Hi, fencing-switcher is controlling this annotation to indicate if node reboot initiated by user and hence node does not requires fencing.

The current design is:

  • to add annotation when node is operable (eg. having Ready state, kubelet is up and able to run new workload)
  • to remove annotation when node is doing graceful shutdown (to not initiate fencing procedure due fact that node changed state to NotReady)

If you want to control this annotation by yourself just remove fencing-switcher from these nodes by removing the label for it's daemonset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants