Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename binary artifact to kuzu in CMakelists.txt #3458

Closed
3 tasks done
mewim opened this issue May 7, 2024 · 0 comments
Closed
3 tasks done

Rename binary artifact to kuzu in CMakelists.txt #3458

mewim opened this issue May 7, 2024 · 0 comments
Assignees
@mewim

Comments

@mewim
Copy link
Collaborator

mewim commented May 7, 2024 •
edited

Currently the default artifact name for the shell is kuzu_shell by default and we change the name manually for our CI pieplines. We should just default to the name kuzu in CMakelists.txt so we do not have to do the renaming.

  • Change the name in CMakelists.txt.
  • Revisit all the CI jobs.
  • Remove bin.install_symlink from our brew formula.
@mewim mewim self-assigned this May 7, 2024
@mewim mewim mentioned this issue May 7, 2024
Merged
6 tasks
mewim added a commit that referenced this issue May 14, 2024
@mewim
Address #3458
22d8bc8
mewim added a commit that referenced this issue May 14, 2024
@mewim
Port changes from 0.4.2 to master (#3493)
a4b3e94 
* Update project version to 0.4.1

* Try to address #3478 by disabling LTO in release binaries

* Update version to 0.4.2

* Update Rust version

* Address #3458

* Disable renaming on Windows due to conflict

* Add comment

* Do not strip binary during installation

* Fix Rust
@mewim mewim closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mewim mewim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mewim