Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Be able to define kurtosis flags in an argument file #2428

Open
barnabasbusa opened this issue May 7, 2024 · 0 comments
Open

FR: Be able to define kurtosis flags in an argument file #2428

barnabasbusa opened this issue May 7, 2024 · 0 comments
Labels
cli For bugs relating to the CLI feature request nice to have Nice to have feature

Comments

@barnabasbusa
Copy link
Contributor

Background & motivation

It would be great to have a single document that defines all the runtime parameters of a kurtosis run.

For example, right now we have to pass all the runtime arguments in the same command, and if we forget to run it, we might have a different enclave name, or different pull policy than expected.

Desired behaviour

I would like to be able to pass the kurtosis runtime parameters in the same argument file that I pass for a package.
This should be parsed, and if someone runs the same yaml file, they should get exactly the same runtime.

For example:

Current setup:

participants:
  - count: 2
network_params:  
  preset: minimal
additional_services: 
  - dora
  - tx_spammer

tx_spammer_params:
  tx_spammer_extra_args: ["--accounts=1", "--txcount=1"]

Runtime:
kurtosis run github.com/kurtosis-tech/ethereum-package@bbusa/test1 --args-file <url> --verbosity detailed --image-download always --enclave testing .... (potentially any of the kurtosis runtime variables)

Future setup:

kurtosis:
  url: github.com/kurtosis-tech/ethereum-package
    branch: bbusa/test1
  verbosity: detailed
  image-download: always
  enclave: testing
  args-file: .
participants:
  - el_type: nethermind
    cl_type: lighthouse
network_params:  
  preset: minimal
additional_services: 
  - dora
  - tx_spammer

tx_spammer_params:
  tx_spammer_extra_args: ["--accounts=1", "--txcount=1"]

Runtime: kurtosis run

This should ideally work in kurtosis cloud too.

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.

What area of the product does this pertain to?

CLI: the Command Line Interface

@github-actions github-actions bot added cli For bugs relating to the CLI nice to have Nice to have feature labels May 7, 2024
@barnabasbusa barnabasbusa changed the title FR: Be able to define kurtosis flags in a argument file FR: Be able to define kurtosis flags in an argument file May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli For bugs relating to the CLI feature request nice to have Nice to have feature
Projects
None yet
Development

No branches or pull requests

1 participant