Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if extra params are provided in an args file #2398

Open
tedim52 opened this issue Apr 23, 2024 · 0 comments
Open

Don't fail if extra params are provided in an args file #2398

tedim52 opened this issue Apr 23, 2024 · 0 comments
Labels
bug Something isn't working painful Painful bug

Comments

@tedim52
Copy link
Contributor

tedim52 commented Apr 23, 2024

What's your CLI version?

0.88.18

Description & steps to reproduce

Context: 0xPolygon/kurtosis-cdk#79 (comment)

params.yml:

arg1: false
arg2: true

sub.star:

def run(plan, arg2):
     ... 
kurtosis run --args-file params.yml --main-file sub.star .

The command fails with:

There was an error interpreting Starlark code 
Evaluation error: function run got an unexpected keyword argument "arg1"
        at [github.com/0xPolygon/kurtosis-cdk/zkevm_permissionless_node.star:8:28]: run

Desired behavior

The command doesn't fail. This way you can use one args file to provide values for multiple Starlark scripts.

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.

What area of the product does this pertain to?

Other: anything not covered by the above

@tedim52 tedim52 added the bug Something isn't working label Apr 23, 2024
@github-actions github-actions bot added the painful Painful bug label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working painful Painful bug
Projects
None yet
Development

No branches or pull requests

1 participant