Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in checking weights sum to 1 #81

Open
BeyondTheProof opened this issue Feb 1, 2021 · 1 comment
Open

Bug in checking weights sum to 1 #81

BeyondTheProof opened this issue Feb 1, 2021 · 1 comment

Comments

@BeyondTheProof
Copy link

Hi Avanti, I've reopened this issue to fix a small bug. You had a < instead of > in your fix. I left a one-line review on the PR.

Originally posted by @BeyondTheProof in #79 (comment)

@AvantiShri
Copy link
Collaborator

Thanks, I have a PR for that here #82 and will merge into master once the tests pass. Also version 10 had introduced a new default of variable-length seqlet identification, but I've decided to roll back that default since it doesn't seem as good as the previous fixed-length seqlet identification default. I'll merge it into master when it passes tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants