Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected keyword argument 'kmer_len' in constructor call of modisco.tfmodisco_workflow.seqlets_to_patterns.TfModiscoSeqletsToPatternsFactory #71

Open
ofiryaish opened this issue Oct 3, 2020 · 1 comment

Comments

@ofiryaish
Copy link

Hello,

Does new versions support kmer_len, num_gaps, and num_mismatches in modisco.tfmodisco_workflow.seqlets_to_patterns.TfModiscoSeqletsToPatternsFactory?

I get the error that the constructor does know these keyword. The program runs, but why this error occurs? Does in new versions we changing these make any change?

@AvantiShri
Copy link
Collaborator

Hi @ofiryaish,

So the recent changes I made in response to your GitHub issue should not have affected those arguments. The version where those arguments were affected was v0.5.8.0, but I think you were already using that version (https://github.com/kundajelab/tfmodisco/releases/tag/v0.5.8.0), and in any case the changes in v0.5.8.0 were done in a way that maintained backwards compatibility (insofar as I tested them). Can you maybe give a screenshot/paste the call to tfmodisco that gives the error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants